Skip to content

Clean up the eager formatting API#153508

Merged
rust-bors[bot] merged 10 commits intorust-lang:mainfrom
JonathanBrouwer:improved_eager_format
Mar 7, 2026
Merged

Clean up the eager formatting API#153508
rust-bors[bot] merged 10 commits intorust-lang:mainfrom
JonathanBrouwer:improved_eager_format

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Mar 6, 2026 •
edited
Loading

For #151366 (comment)

Previously eager formatting worked by throwing the arguments into a diag, formatting, then removing the args again. This is ugly so instead we now just do the formatting completely separately.
This PR has nice commits, so I recommend reviewing commit by commit.

r? @GuillaumeGomez

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 6, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 6, 2026
Open
8 tasks
@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review March 6, 2026 18:10
@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

rustc_errors::formatting was changed

cc @davidtwco, @TaKO8Ki

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to constck

cc @fee1-dead

rustc_macros::diagnostics was changed

cc @davidtwco, @TaKO8Ki

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Mar 6, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 6, 2026
@bors
Auto merge of #153508 - JonathanBrouwer:improved_eager_format, r=<try>
48c772e 
Clean up the eager formatting API
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 6, 2026

☀️ Try build successful (CI)
Build commit: 48c772e (48c772ee3596abfd73f472d0115cdcd977f51de9, parent: a3ac2f21b3ae29145f587553efa8f76c16043777)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Mar 6, 2026

Finished benchmarking commit (48c772e): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.3% [3.7%, 4.8%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.299s -> 478.644s (-0.55%)
Artifact size: 395.15 MiB -> 395.10 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Mar 7, 2026

@bors r=GuillaumeGomez rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 7, 2026

📌 Commit 7baf2be has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 7, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 7, 2026
@bors
Auto merge of #153519 - JonathanBrouwer:rollup-Soq8THm, r=JonathanBro…
ea5573a 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #149937 (spliit out `linker-info` from `linker-messages`)
 - #153503 (Fallback to fat LTO for -Clto=thin in cg_gcc)
 - #153346 (move never type tests to subdirectories and add some comments)
 - #153371 (Fix LegacyKeyValueFormat report from docker build: arm)
 - #153508 (Clean up the eager formatting API)
@rust-bors rust-bors bot merged commit f540b27 into rust-lang:main Mar 7, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Mar 7, 2026
@rust-timer
Unrolled build for #153508
4ec5c50 
Rollup merge of #153508 - JonathanBrouwer:improved_eager_format, r=GuillaumeGomez

Clean up the eager formatting API

For #151366 (comment)

Previously eager formatting worked by throwing the arguments into a diag, formatting, then removing the args again. This is ugly so instead we now just do the formatting completely separately.
This PR has nice commits, so I recommend reviewing commit by commit.

r? @GuillaumeGomez
@rustbot rustbot added this to the 1.96.0 milestone Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer @rustbot @rust-log-analyzer @rust-timer @GuillaumeGomez